Feat: checkpoint optimize function to restart after crash#206
Merged
tchaton merged 20 commits intoLightning-AI:mainfrom Jul 5, 2024
Merged
Feat: checkpoint optimize function to restart after crash#206tchaton merged 20 commits intoLightning-AI:mainfrom
tchaton merged 20 commits intoLightning-AI:mainfrom
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #206 +/- ##
=====================================
Coverage ? 77%
=====================================
Files ? 33
Lines ? 4667
Branches ? 0
=====================================
Hits ? 3588
Misses ? 1079
Partials ? 0 |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: thomas chaton <thomas@grid.ai>
justusschock
approved these changes
Jul 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #137 .
Make
optimize functionfault-tolerant and restart from last checkpoint after an unexpected crash.The checkpoint feature is supported for
mode = "None | append".Overwritemode will overwrite everything, even checkpoints.🚧 Warning: It doesn't support generator functions as of now. It'll be added in the next PR.
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃