-
Notifications
You must be signed in to change notification settings - Fork 66
ci:Update CI testing matrix for Python versions #589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #589 +/- ##
====================================
+ Coverage 80% 84% +4%
====================================
Files 43 43
Lines 6463 6463
====================================
+ Hits 5156 5401 +245
+ Misses 1307 1062 -245 🚀 New features to boost your workflow:
|
is this pr still in WIP? Is there anything else that you intend to add? |
Not really. I just had a concern: adding more Python versions might introduce unnecessary tests and increase GitHub Actions usage. @Borda @tchaton, what are your thoughts on this? Should we expand the Python version matrix further, or is the current setup sufficient? I added for Python 3.11 last week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems enough
Tests on both
|
Seems that the tests are running for 40 minutes, which is quite a significant time, so can we run them in parallel? |
seems it did not help |
What does this PR do ?
Expand the CI testing matrix to include Python versions 3.12 and 3.13.