Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing r1 prompt style #1929

Merged
merged 4 commits into from
Jan 31, 2025
Merged

add missing r1 prompt style #1929

merged 4 commits into from
Jan 31, 2025

Conversation

ali-alshaar7
Copy link
Contributor

No description provided.

@ali-alshaar7 ali-alshaar7 marked this pull request as draft January 30, 2025 23:17
@ali-alshaar7 ali-alshaar7 marked this pull request as ready for review January 31, 2025 14:27
t-vi
t-vi approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ali-alshaar7

@t-vi
Copy link
Collaborator

t-vi commented Jan 31, 2025

Needs a look at the tests, though.

@ali-alshaar7 ali-alshaar7 enabled auto-merge (squash) January 31, 2025 15:22
@ali-alshaar7 ali-alshaar7 merged commit c7af97d into main Jan 31, 2025
9 checks passed
@ali-alshaar7 ali-alshaar7 deleted the alia/r1prompts branch January 31, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-vi t-vi t-vi approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ali-alshaar7 @t-vi