-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Make WandbLogger
upload models from all ModelCheckpoint
callbacks, not just one
#20191
Merged
Borda
merged 7 commits into
Lightning-AI:master
from
cgebbe:cgebbe-wandb-all-checkpoints
Mar 14, 2025
Merged
Fix: Make WandbLogger
upload models from all ModelCheckpoint
callbacks, not just one
#20191
Borda
merged 7 commits into
Lightning-AI:master
from
cgebbe:cgebbe-wandb-all-checkpoints
Mar 14, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WandbLogger
upload models from all ModelCheckpoint
callbacks, not just one
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20191 +/- ##
=========================================
- Coverage 88% 79% -9%
=========================================
Files 267 264 -3
Lines 23355 23301 -54
=========================================
- Hits 20458 18348 -2110
- Misses 2897 4953 +2056 🚀 New features to boost your workflow:
|
Borda
approved these changes
Mar 14, 2025
Borda
pushed a commit
that referenced
this pull request
Mar 18, 2025
…backs, not just one (#20191) * test: add failing test using two callbacks * fix: save all checkpoint callbacks to wandb * chore: fix mypy * chore: fix ruff --------- Co-authored-by: Christian Gebbe <> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit bd9d114)
lexierule
pushed a commit
that referenced
this pull request
Mar 18, 2025
…backs, not just one (#20191) * test: add failing test using two callbacks * fix: save all checkpoint callbacks to wandb * chore: fix mypy * chore: fix ruff --------- Co-authored-by: Christian Gebbe <> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit bd9d114)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
log_model=True
ModelCheckpoint
callbacksTwo questions
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20191.org.readthedocs.build/en/20191/