Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Make WandbLogger upload models from all ModelCheckpoint callbacks, not just one #20191

Merged
merged 7 commits into from
Mar 14, 2025

Conversation

cgebbe
Copy link
Contributor

@cgebbe cgebbe commented Aug 12, 2024

What does this PR do?

  • Given a trainer with wandb logger and log_model=True
  • and two ModelCheckpoint callbacks
  • When training
  • Then only models from one checkpoint are uploaded to wandb.

Two questions

  • how shall I add CHANGELOG entry?
  • do you want this e.g. squashed in one commit?
Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs) - yes
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--20191.org.readthedocs.build/en/20191/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 12, 2024
@cgebbe cgebbe changed the title Cgebbe wandb all checkpoints Fix: Make WandbLogger upload models from all ModelCheckpoint callbacks, not just one Aug 12, 2024
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79%. Comparing base (96df8c4) to head (09097ee).
Report is 4 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (96df8c4) and HEAD (09097ee). Click for more details.

HEAD has 105 uploads less than BASE
Flag BASE (96df8c4) HEAD (09097ee)
cpu 48 24
python 6 3
lightning_fabric 11 0
pytest 27 0
lightning 31 15
python3.11 12 6
python3.10 12 6
python3.12.7 18 9
gpu 3 0
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #20191     +/-   ##
=========================================
- Coverage      88%      79%     -9%     
=========================================
  Files         267      264      -3     
  Lines       23355    23301     -54     
=========================================
- Hits        20458    18348   -2110     
- Misses       2897     4953   +2056     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Borda Borda requested a review from ethanwharris as a code owner March 14, 2025 09:16
@mergify mergify bot removed the has conflicts label Mar 14, 2025
@Borda Borda merged commit bd9d114 into Lightning-AI:master Mar 14, 2025
79 checks passed
Borda pushed a commit that referenced this pull request Mar 18, 2025
…backs, not just one (#20191)

* test: add failing test using two callbacks
* fix: save all checkpoint callbacks to wandb
* chore: fix mypy
* chore: fix ruff

---------

Co-authored-by: Christian Gebbe <>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit bd9d114)
lexierule pushed a commit that referenced this pull request Mar 18, 2025
…backs, not just one (#20191)

* test: add failing test using two callbacks
* fix: save all checkpoint callbacks to wandb
* chore: fix mypy
* chore: fix ruff

---------

Co-authored-by: Christian Gebbe <>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit bd9d114)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants