Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update comet_ml logger for compatibility #20275

Merged
merged 41 commits into from
Mar 12, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
07e802d
remove deprecated rest api key
japdubengsub Sep 3, 2024
075b581
do not end experiment automatically
japdubengsub Sep 3, 2024
be371cd
support nested hyperparams
japdubengsub Sep 3, 2024
7481e33
use special internal methods while logging
japdubengsub Sep 3, 2024
9d9c86f
linter fix
japdubengsub Sep 4, 2024
f2cd1b9
use comet_ml.start() instead of manual initialization
japdubengsub Sep 4, 2024
946c92e
update unit tests
japdubengsub Sep 5, 2024
3a2a27d
add PR suggestions
japdubengsub Sep 9, 2024
05de746
fix mypy check
japdubengsub Sep 9, 2024
e1f9042
fix mypy check #2
japdubengsub Sep 10, 2024
d9c7480
update changelog
japdubengsub Sep 11, 2024
0fea284
Update CHANGELOG.md with PR number
japdubengsub Sep 11, 2024
beb8d52
use ` notation
japdubengsub Sep 25, 2024
5ab3662
enable keyword arguments only
japdubengsub Sep 25, 2024
036a2eb
fix linter warning
japdubengsub Sep 25, 2024
49722b1
Merge branch 'master' into feature/comet-logger-update
japdubengsub Sep 30, 2024
a804240
fix unit tests
japdubengsub Sep 30, 2024
cb2ce52
add support of old style "experiment_name" argument
japdubengsub Oct 2, 2024
caab338
fix linter warning
japdubengsub Oct 2, 2024
5c01290
remove type hints from docstrings
japdubengsub Oct 4, 2024
06a8028
revert back default values in docstring examples
japdubengsub Oct 8, 2024
467378d
flatten nested params
japdubengsub Oct 8, 2024
512d763
fix unit test mock issue
japdubengsub Oct 8, 2024
a785341
fix cli arguments unit test
japdubengsub Oct 8, 2024
ad2d319
add unit tests for public/double underscore methods
japdubengsub Oct 10, 2024
8108320
Merge branch 'master' into feature/comet-logger-update
japdubengsub Oct 10, 2024
59d7384
Merge branch 'master' into feature/comet-logger-update
Lothiraldan Oct 23, 2024
73c4773
Merge branch 'master' into feature/comet-logger-update
Lothiraldan Nov 5, 2024
8ee6e04
Merge branch 'master' into feature/comet-logger-update
Lothiraldan Nov 12, 2024
4ba9bf2
Merge branch 'master' into feature/comet-logger-update
Lothiraldan Nov 13, 2024
f11232b
Merge branch 'master' into feature/comet-logger-update
alexkuzmik Nov 17, 2024
7358aef
Merge branch 'master' into feature/comet-logger-update
japdubengsub Nov 25, 2024
27bdbcf
fix linter warning
japdubengsub Nov 25, 2024
dc048b1
Merge branch 'master' into feature/comet-logger-update
Lothiraldan Dec 4, 2024
3c84f84
Merge branch 'master' into feature/comet-logger-update
Lothiraldan Dec 12, 2024
7e15ff5
Merge branch 'master' into feature/comet-logger-update
Lothiraldan Dec 18, 2024
e7e579a
Merge branch 'master' into feature/comet-logger-update
Lothiraldan Feb 17, 2025
d7d3d9c
Merge remote-tracking branch 'upstream/master' into feature/comet-log…
japdubengsub Mar 12, 2025
e882468
fix linter warning
japdubengsub Mar 12, 2025
3bb1fbc
pass `online` arg to ExperimentConfig
japdubengsub Mar 12, 2025
9e7a3cc
fix comet logger test
japdubengsub Mar 12, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lightning/pytorch/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).


- Added a new `checkpoint_path_prefix` parameter to the MLflow logger which can control the path to where the MLflow artifacts for the model checkpoints are stored ([#20538](https://github.com/Lightning-AI/pytorch-lightning/pull/20538))

- CometML logger was updated to support the recent Comet SDK ([#20275](https://github.com/Lightning-AI/pytorch-lightning/pull/20275))


### Removed
Expand Down
Loading
Loading