Update (ci): github action's artifact upgrade v4#20500
Merged
alleeclark merged 14 commits intomasterfrom Dec 17, 2024
Merged
Conversation
751664d to
b485017
Compare
alleeclark
commented
Dec 16, 2024
Contributor
4b47796 to
7ab9753
Compare
…edirects intel.com documentation
7ab9753 to
2afe620
Compare
alleeclark
commented
Dec 17, 2024
Borda
requested changes
Dec 17, 2024
Collaborator
There was a problem hiding this comment.
The direction is good, it just needs some more work with adding patterns and making unique uploads...
pls, have look what I gave done earlier this week for shared utils project: Lightning-AI/utilities#344
for more information, see https://pre-commit.ci
…I/pytorch-lightning into fix_allee_github_artifacts_upload_and_download_eol_v4
This reverts commit ed44fec.
Borda
reviewed
Dec 17, 2024
Borda
reviewed
Dec 17, 2024
Borda
reviewed
Dec 17, 2024
Borda
reviewed
Dec 17, 2024
Borda
reviewed
Dec 17, 2024
Borda
approved these changes
Dec 17, 2024
Contributor
Author
Thanks. I reviewed the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Why
We received the email below stating that we need to upgrade by January.
Here is the recommended upgrade guide that I followed.
Does this introduce breaking change?
According to Github after Jan 9th if we have not upgraded there will be issues running pipelines.
Test Plan
-- dist-packages-870cec2e4fc4ca4f9ea49a94862b7412bd914431.zip
-- dist-packages-e9100e548a5f90fb4e90a189b6f6c80dae4a37e7.zip
Before submitting
- Was this **discussed/agreed** via a GitHub issue? (not for typos and docs) - [ ] Did you read the [contributor guideline](https://github.com/Lightning-AI/lightning/blob/master/.github/CONTRIBUTING.md), **Pull Request** section? - [ ] Did you make sure your **PR does only one thing**, instead of bundling different changes together? - Did you make sure to **update the documentation** with your changes? (if necessary) - Did you write any **new necessary tests**? (not for typos and docs) - [ ] Did you verify new and **existing tests pass** locally with your changes? - Did you list all the **breaking changes** introduced by this pull request? - Did you **update the CHANGELOG**? (not for typos, docs, test updates, or minor internal changes/refactors)PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20500.org.readthedocs.build/en/20500/
cc @Borda