refactor: try catch a more specific exception during log_metrics.#21271
Open
GdoongMathew wants to merge 13 commits intoLightning-AI:masterfrom
Open
refactor: try catch a more specific exception during log_metrics.#21271GdoongMathew wants to merge 13 commits intoLightning-AI:masterfrom
GdoongMathew wants to merge 13 commits intoLightning-AI:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21271 +/- ##
=======================================
Coverage 87% 87%
=======================================
Files 270 270
Lines 24078 24078
=======================================
+ Hits 20866 20871 +5
+ Misses 3212 3207 -5 |
SkafteNicki
approved these changes
Oct 7, 2025
deependujha
reviewed
Oct 8, 2025
GdoongMathew
commented
Oct 8, 2025
deependujha
approved these changes
Oct 8, 2025
bhimrazy
approved these changes
Nov 21, 2025
Contributor
Author
|
bump~ |
tchaton
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Handle a more specific exception class during
TensorBoardLogger.log_metrics, and remove its todo.Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21271.org.readthedocs.build/en/21271/