Skip to content

refactor: try catch a more specific exception during log_metrics.#21271

Open
GdoongMathew wants to merge 13 commits intoLightning-AI:masterfrom
GdoongMathew:refactor/tensorboard_log_metrics_handling
Open

refactor: try catch a more specific exception during log_metrics.#21271
GdoongMathew wants to merge 13 commits intoLightning-AI:masterfrom
GdoongMathew:refactor/tensorboard_log_metrics_handling

Conversation

@GdoongMathew
Copy link
Contributor

@GdoongMathew GdoongMathew commented Oct 6, 2025

What does this PR do?

Handle a more specific exception class during TensorBoardLogger.log_metrics, and remove its todo.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21271.org.readthedocs.build/en/21271/

@github-actions github-actions bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels Oct 6, 2025
@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87%. Comparing base (c05cadb) to head (6d03f4a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21271   +/-   ##
=======================================
  Coverage      87%      87%           
=======================================
  Files         270      270           
  Lines       24078    24078           
=======================================
+ Hits        20866    20871    +5     
+ Misses       3212     3207    -5     

@GdoongMathew
Copy link
Contributor Author

bump~

@deependujha deependujha added the ready to be merged PRs ready to be merged label Jan 17, 2026
@deependujha deependujha added the exec-signoff-required PR is fully reviewed and approved by maintainers. Only the CEO's or CTO's approval is pending. label Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

exec-signoff-required PR is fully reviewed and approved by maintainers. Only the CEO's or CTO's approval is pending. fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package ready to be merged PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants