Description on how to run tests & build docs #2500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
Borda,
justusschock and
stancld
as code owners
github-actions
bot
removed
the
documentation
Borda
reviewed
Apr 13, 2024
Borda
approved these changes
Apr 13, 2024
Collaborator
Borda
left a comment
Borda
left a comment
There was a problem hiding this comment.
It can be also just make test
Co-authored-by: Jirka Borovec <[email protected]>
for more information, see https://pre-commit.ci
github-actions
bot
removed
the
documentation
Borda
reviewed
Apr 17, 2024
Collaborator
|
it seems fine, but somehow, all CPU tests are failing at the stage of collecting tests... |
Borda
reviewed
Apr 23, 2024
Collaborator
Author
|
Not sure why the collection is failing, seems independent of the changes in the PR |
Collaborator
I may not agree as master and other PR proceed and here constantly failed... |
for more information, see https://pre-commit.ci
Borda
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2500 +/- ##
======================================
Coverage 69% 69%
======================================
Files 313 313
Lines 17598 17598
======================================
Hits 12147 12147
Misses 5451 5451 |
Borda
reviewed
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Just because I sometimes forget how to run the ddp/non-ddp tests...
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2500.org.readthedocs.build/en/2500/