Skip to content

wasmtestreport.py Test suite revision #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 7, 2025
Merged

Conversation

DyanB
Copy link
Contributor

@DyanB DyanB commented Jul 30, 2025

Reference issue: Link

This PR takes care of some of the issues listed in Issue 291

  • Removed chdir calls by using a wrapper for subprocess.run
  • Added Logging for the subprocess calls
  • Can run multiple individual test files now

@DyanB DyanB requested review from m-hemmings and rennergade July 30, 2025 16:53
@rennergade rennergade requested review from J7-7-7 and Karan-05 July 30, 2025 17:40
Copy link
Contributor

@J7-7-7 J7-7-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I don't see any major issues

Karan-05
Karan-05 previously approved these changes Jul 31, 2025
Copy link

@Karan-05 Karan-05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Suggestion
We could use logger.debug instead of print ?? as logging adds timestamps, severity labels etc

Copy link
Member

@m-hemmings m-hemmings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my requests have been fixed, thank you!

Copy link

@Karan-05 Karan-05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rennergade rennergade merged commit dc8501d into main Aug 7, 2025
2 checks passed
@DyanB
Copy link
Contributor Author

DyanB commented Aug 7, 2025

Tasks done:
Ref: Issue 291
Allow running individual test files.
Go easy on the chdirs.
Improve output and debugging options.

Ongoing tasks:
Get rid of absolute paths.
Revise programming style.
Temporary directory for all test artifacts
Revise test setup and tear down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants