-
Notifications
You must be signed in to change notification settings - Fork 11
wasmtestreport.py Test suite revision #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ved logging and debugging options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I don't see any major issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Suggestion
We could use logger.debug instead of print ?? as logging adds timestamps, severity labels etc
…port Updating my branch with the main branch
…fault checks with a function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All my requests have been fixed, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tasks done: Ongoing tasks: |
Reference issue: Link
This PR takes care of some of the issues listed in Issue 291