Skip to content

Writev #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 17, 2024
Merged

Writev #245

merged 5 commits into from
May 17, 2024

Conversation

rennergade
Copy link
Contributor

Description

Fixes # (issue)

Increases performance of applications such as nginx by adding the writev() system call. Right now we only implement this for INET/TCP sockets which will call down to the native system call.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Added test to rust suite
Lind test suite
nginx performance tests

Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been added to a pull request and/or merged in other modules (native-client, lind-glibc, lind-project)

Copy link
Member

@Yaxuan-w Yaxuan-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall logic makes sense to me and structure is clear. LGTM!

@rennergade rennergade merged commit e15acc9 into develop May 17, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants