Socket syscall #247
Merged
Socket syscall #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinCappos
requested changes
May 19, 2024
Signed-off-by: Yashaswi Makula <[email protected]>
JustinCappos
requested changes
May 20, 2024
…scall Signed-off-by: Yashaswi Makula <[email protected]>
yashaswi2000
force-pushed
the
rupesh_syscall
branch
from
f7c1264 to
5eeb01c
Compare
Signed-off-by: Yashaswi Makula <[email protected]>
JustinCappos
approved these changes
May 20, 2024
|
I think it makes sense to merge this and just keep a link to it as reference in the documentation issue rather than keeping it open. @rupeshkoushik07 can you update this for the newer RustDoc and we'll get it approved? |
|
I have updated the comments @rennergade |
rennergade
requested changes
Jul 5, 2024
|
lets also change the name of this PR to socket comments or something like that so its not confusing once we merge |
|
This looks good and up to date and IDT we need this as a non-merged example anymore. Going to merge now. |
Anway-Agte
pushed a commit
that referenced
this pull request
Jul 15, 2024
* example_PR * formating unit tests for socket_syscall Signed-off-by: Yashaswi Makula <[email protected]> * updating socket syscall tests and adding error checking for socket syscall Signed-off-by: Yashaswi Makula <[email protected]> * updating comments and tests Signed-off-by: Yashaswi Makula <[email protected]> * update comments * update blocking comment * update the comments * update panics --------- Signed-off-by: Yashaswi Makula <[email protected]> Co-authored-by: Yashaswi Makula <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an example pull request showing how to add comments for syscalls, in this case, for the socket_syscall function.
unit tests are updated by @yashaswi2000
Fixes # (issue)
Type of change
How Has This Been Tested?
lind_project/tests/test_cases/test_a.clind_project/tests/test_cases/test_b.cChecklist: