Skip to content

readat/writeat #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 22, 2024
Merged

readat/writeat #249

merged 4 commits into from
May 22, 2024

Conversation

rennergade
Copy link
Contributor

… call

Description

change read and write to use readat and writeat, removing excess seek call

Fixes # (issue)
Minor performance improvements

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Rust suite/lamp tests

Copy link
Member

@Yaxuan-w Yaxuan-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

read_at and write_at will read data directly from the specified offset of the file. Change to use them will avoid using seek() and make the code more clear. The overall logic makes sense to me so approved.

Copy link
Member

@JustinCappos JustinCappos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also quite confusing with readat calling read_at, etc. More comments about why you are doing what you are doing / code clarity would be a big help here.

@rennergade rennergade merged commit fec5ee3 into develop May 22, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants