Add UDS/Pipe to writev()/Fix UDS EPIPE on send #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rennergade
requested review from
JustinCappos,
yzhang71,
Yaxuan-w,
yizhuoliang,
ve1nard and
namanlalitnyu
yzhang71
reviewed
May 23, 2024
| for _iov in 0..iovcnt { | ||
| unsafe { | ||
| let iovec = *ptr; | ||
| assert!(!ptr.is_null()); |
There was a problem hiding this comment.
This check is performed after dereferencing the pointer, which is not right to me. This assertion should be placed before dereferencing to prevent undefined behavior.
rennergade
commented
May 23, 2024
| @@ -514,7 +514,9 @@ mod tests { | |||
| let emulated_file = EmulatedFile::new(file_path.clone(), file_content.len()).unwrap(); | |||
|
|
|||
| let mut buffer = vec![0; file_content.len()]; | |||
| let bytes_read = emulated_file.readat(buffer.as_mut_ptr(), buffer.len(), 0).unwrap(); | |||
| let bytes_read = emulated_file | |||
There was a problem hiding this comment.
everything in this file is just rust fmt fixing what I didn't format in the read_at PR
Yaxuan-w
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
Type of change
How Has This Been Tested?
Added unix domain writev test
Lamp tests
Test suite
Checklist: