Skip to content

Random port #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 12, 2024
Merged

Random port #258

merged 6 commits into from
Jun 12, 2024

Conversation

rupeshkoushik07
Copy link
Member

@rupeshkoushik07 rupeshkoushik07 commented Jun 7, 2024

Description

Fixes # 246

Type of change

Added random ports.

  • New feature (adds random ports)

How Has This Been Tested?

  • Test A - lind_project/tests/test_cases/test_a.c
  • Test B - lind_project/tests/test_cases/test_b.c

Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been added to a pull request and/or merged in other modules (native-client, lind-glibc, lind-project)

@JustinCappos
Copy link
Member

FYI: perhaps mark as draft until it's ready...

@rupeshkoushik07 rupeshkoushik07 marked this pull request as draft June 7, 2024 21:05
@rupeshkoushik07 rupeshkoushik07 marked this pull request as ready for review June 11, 2024 15:36
Copy link
Contributor

@rennergade rennergade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Needs two more comments I think.

Copy link
Member

@JustinCappos JustinCappos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fixes. Looks good!

@rennergade rennergade merged commit a684d46 into develop Jun 12, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants