Skip to content

ioctl_syscall updates #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 20, 2024
Merged

ioctl_syscall updates #265

merged 5 commits into from
Jun 20, 2024

Conversation

ve1nard
Copy link
Contributor

@ve1nard ve1nard commented Jun 14, 2024

Description

Fixes # (issue)

The following changes include more elaborate comments and new unit tests for ioctl_syscall.

Type of change

  • More detailed comments for ioctl_syscall
  • New unit tests for ioctl_syscall

How Has This Been Tested?

To run the tests, we need to run cargo test --lib command inside the safeposix-rust directory.

All the tests are present under this directory: lind_project/src/safeposix-rust/src/tests/fs_tests.rs

  • Test A - lut_lind_fs_ioctl_valid_args()
  • Test B - ut_lind_fs_ioctl_invalid_args()

Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been added to a pull request and/or merged in other modules (native-client, lind-glibc, lind-project)

@JustinCappos
Copy link
Member

Okay, let's try to trade reviews with our peers too so you can all learn from each other. Maybe have @namanlalitnyu take a look first? I can do a review after.

(Feel free to start on other calls / review other students' PRs in the meantime.)

@ve1nard ve1nard requested a review from rennergade June 20, 2024 17:55
Copy link
Contributor

@rennergade rennergade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think once you get the style updated this is ready to go!

Copy link
Contributor

@rennergade rennergade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready. Approved and great job.

Copy link
Member

@JustinCappos JustinCappos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JustinCappos JustinCappos merged commit 0f77f88 into develop Jun 20, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants