-
Notifications
You must be signed in to change notification settings - Fork 10
ioctl_syscall updates #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Okay, let's try to trade reviews with our peers too so you can all learn from each other. Maybe have @namanlalitnyu take a look first? I can do a review after. (Feel free to start on other calls / review other students' PRs in the meantime.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think once you get the style updated this is ready to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ready. Approved and great job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Fixes # (issue)
The following changes include more elaborate comments and new unit tests for ioctl_syscall.
Type of change
How Has This Been Tested?
To run the tests, we need to run cargo test --lib command inside the safeposix-rust directory.
All the tests are present under this directory: lind_project/src/safeposix-rust/src/tests/fs_tests.rs
lut_lind_fs_ioctl_valid_args()
ut_lind_fs_ioctl_invalid_args()
Checklist: