-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Context Path issue when running application in a servlet container #52
Open
larsgsvensson
wants to merge
3
commits into
LinkedDataFragments:master
Choose a base branch
from
larsgsvensson:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hey can access protected methods and inner classes
Added dependency on mockito packaging as war now excludes all jetty*-Jars since they are not needed when running the application in an external servlet container
…ntainer since the algorithm did not take the servlet path into account.
Hi, would like to merge this, but it seems to have errors:
|
The non-functional reformatting in this pull-request makes the review very challenging. Would it be possible to resubmit, only including the functional updates? |
awoods
pushed a commit
to awoods/Server.Java
that referenced
this pull request
Oct 25, 2019
Prior to this update, when deploying to a servlet container: - the style.css does not resolve - the favicon.ico does not resolve - the "Linked Data Fragments" image does not resolve - the contexts of datasource do not resolve Resolves: LinkedDataFragments#52
awoods
pushed a commit
to awoods/Server.Java
that referenced
this pull request
Oct 25, 2019
Prior to this update, when deploying to a servlet container: - the style.css does not resolve - the favicon.ico does not resolve - the "Linked Data Fragments" image does not resolve - the contexts of datasource do not resolve Resolves: LinkedDataFragments#52
awoods
pushed a commit
to awoods/Server.Java
that referenced
this pull request
Oct 26, 2019
Prior to this update, when deploying to a servlet container: - the style.css does not resolve - the favicon.ico does not resolve - the "Linked Data Fragments" image does not resolve - the contexts of datasource do not resolve Resolves: LinkedDataFragments#52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the application i a servlet container (e. g. Tomcat) the dataset URLs were not properly built since the algorithm did not cater for the servlet path.
In order to write the test cases, I also had to move the tests into the same packages as the classes they test so that they can access protected methods and inner classes