feat: change font-awesome icon lib by fork-awesome#43
Open
abs0lom wants to merge 1 commit intoLinuxBozo:masterfrom
Open
feat: change font-awesome icon lib by fork-awesome#43abs0lom wants to merge 1 commit intoLinuxBozo:masterfrom
abs0lom wants to merge 1 commit intoLinuxBozo:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I wanted to add a matrix.org link to my list of profiles, I saw that font-awesome did not have this icon.
The fork of this project, fork-awesome, has this icon and allows PRs to add new icons.
So I created a branch to change one for the other.
However, I'm not sure if another icon than the matrix.org one is missing in font-awesome. I'll let you close this PR if you don't think this change is appropriate.
Thanks for your work