Skip to content

Gmoccapy: Fix odd spindle behavior when using G96 #3450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Sigma1912
Copy link
Contributor

Fixes issue #3447:

  • gui spindle speed display showing a very large number when G96 (CSS) mode is used
  • spindle.0.speed-out pin being reset to a wrong value when the gui spindle buttons are updated after calling G96 through MDI

Fixes issue LinuxCNC#3447:
-  gui spindle speed display showing a very large number when G96 (CSS) mode is used
-  spindle.0.speed-out pin being reset to a wrong value when the gui spindle buttons are updated
 after calling G96 through MDI
@andypugh andypugh requested a review from gmoccapy May 24, 2025 15:24
@andypugh
Copy link
Collaborator

Can you rebase this on 2.9? It's a clear bug.

@Sigma1912
Copy link
Contributor Author

I notice that the relevant functions have been somewhat changed in master and I assume that the added lines will also need to be put into my two new functions.
This is 2.9:
2 9

And this is what it should look like in master (the three last lines in each function are new additions made by @hansu ):

master

I'm not sure how this should be handled. Please advice.

@hansu
Copy link
Member

hansu commented May 25, 2025

27e76fd fixes a minor bug so I added it only in master. But can go into 2.9 as well.
Should I cherry pick that into 2.9? Then you have the same base for the lines you are changing/fixing.

@Sigma1912
Copy link
Contributor Author

So can you put this commit into 2.9 before I create mine or should I try to cherry pick this into my PR?

@hansu
Copy link
Member

hansu commented May 25, 2025

No the above mentioned commit is already in 2.9, included in the 2.9.4 release. Github confused me a bit.

@Sigma1912
Copy link
Contributor Author

I see, so it seems that my repo is not up to date, thanks.

@Sigma1912 Sigma1912 closed this May 25, 2025
@Sigma1912
Copy link
Contributor Author

See rebased and improved PR #3454

@Sigma1912 Sigma1912 deleted the Gmoccapy_Fix_odd_spindle_behavior_when_in_G96_mode branch June 18, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gmoccapy - Odd behaviour in G96 (CSS) mode
3 participants