Add Config type to initialize Auto Splitters#712
Merged
CryZe merged 1 commit intoLiveSplit:masterfrom Aug 20, 2023
Merged
Conversation
Rust does not have optional parameters, but we'd like to add more and especially optional parameters when initializing an auto splitter. We now provide a non-exhaustive `Config` type that has suitable default values, that all can be overridden. This also adds a new experimental setting for specifying an "interpreter script path", which allows us to experiment with auto splitters that by themselves implement a script engine and load a script from the file system to run. This script to load from the file system is communicated to the auto splitter via the `SCRIPT_PATH` environment variable.
CryZe
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust does not have optional parameters, but we'd like to add more and especially optional parameters when initializing an auto splitter. We now provide a non-exhaustive
Configtype that has suitable default values, that all can be overridden. This also adds a new experimental setting for specifying an "interpreter script path", which allows us to experiment with auto splitters that by themselves implement a script engine and load a script from the file system to run. This script to load from the file system is communicated to the auto splitter via theSCRIPT_PATHenvironment variable.