Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace img_hash dependency #725

Merged
merged 1 commit into from
Sep 24, 2023
Merged

Commits on Sep 24, 2023

  1. Replace img_hash dependency

    While a visual hash is a good idea, the underlying `tiny-skia` is meant
    to pixel perfectly match `Skia`. This means that our hash doesn't
    actually need to be visual and can be a simple checksum. The `img_hash`
    crate is very unmaintained, so we are forced to compile ever more so
    outdated dependencies. So replacing it by a simple checksum via the
    `seahash` crate makes a lot of sense. The `seahash` crate claims to be
    very fast and also claims that the hashes are suitable for checksums. So
    it sounds like a good crate to use for this. However this means that on
    platforms that don't correctly implement IEEE-754, we can't run the
    rendering tests anymore.
    
    However when it comes to font fallback, it does seem like there's some
    changes between Windows 10 and 11, so we do need to differentiate
    between those now.
    CryZe committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    5d93732 View commit details
    Browse the repository at this point in the history