Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FileSelection Widget #748

Merged
merged 8 commits into from
Dec 21, 2023
Merged

Add FileSelection Widget #748

merged 8 commits into from
Dec 21, 2023

Conversation

AlexKnauth
Copy link
Contributor

@AlexKnauth AlexKnauth commented Dec 11, 2023

This adds a FileSelection Widget to the Auto Splitting Runtime.

Companion PRs:

The asr-debugger and LiveSplit.AutoSplittingRuntime companion branches both implement this as a button in the settings Gui that opens a file dialog when pressed. The user can select a file, and the WASI-compatible path to that file gets stored in the settings map.

The asr companion branch adds a FileSelection type that implements the Widget trait such that an auto-splitter can put it in their settings gui like this:

#[derive(Gui)]
pub struct SettingsGui {
    /// General Settings
    _general_settings: Title,
    /// Select a text file
    #[filter = "*.txt"]
    text_file: FileSelection,
}

@CryZe CryZe added enhancement An improvement for livesplit-core. feature A new user visible feature for livesplit-core. auto splitting This is about the auto splitting implementation. labels Dec 21, 2023
@CryZe CryZe added this to the v0.14 milestone Dec 21, 2023
@CryZe CryZe merged commit 3ac9c0d into LiveSplit:master Dec 21, 2023
76 checks passed
@AlexKnauth AlexKnauth deleted the file-selection branch January 17, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto splitting This is about the auto splitting implementation. enhancement An improvement for livesplit-core. feature A new user visible feature for livesplit-core.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants