Force disable kerning for monospace text #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cosmic-text` unfortunately has no way to turn off kerning yet. However, it's essential for our monospaced text to not have kerning. This implements a small workaround that simply looks up (and caches) the x advance for each glyph and uses it to advance the x coordinate instead of the x advance that comes out of the shaping. This also improves performance because the times on the right side of the layout are all supposed to be monospaced. However, the fact that they didn't use kerning meant that their widths were constantly changing, changing the amount of space that is available on the left side for the text. This caused the text on the left to recalculate its ellipsis overflow state, which often forced the entire background layer to be rerendered.
CryZe
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cosmic-textunfortunately has no way to turn off kerning yet. However, it's essential for our monospaced text to not have kerning. This implements a small workaround that simply looks up (and caches) the x advance for each glyph and uses it to advance the x coordinate instead of the x advance that comes out of the shaping.This also improves performance because the times on the right side of the layout are all supposed to be monospaced. However, the fact that they didn't use kerning meant that their widths were constantly changing, changing the amount of space that is available on the left side for the text. This caused the text on the left to recalculate its ellipsis overflow state, which often forced the entire background layer to be rerendered.