Skip rendering to a canvas with zero dimensions #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the width or height is 0, the element likely isn't mounted into the DOM. This usually isn't a problem, but if we end up resizing the layout, we would resize it based on a size of 0, which would break the entire layout. This happened here: LiveSplit/LiveSplitOne#881 Rendering the layout with a size of 0 is also a waste of time, so this ends up benefiting us in multiple ways.
CryZe
added
bug
CryZe
changed the title
CryZe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the width or height is 0, the element likely isn't mounted into the DOM. This usually isn't a problem, but if we end up resizing the layout, we would resize it based on a size of 0, which would break the entire layout. This happened here:
LiveSplit/LiveSplitOne#881
Rendering the layout with a size of 0 is also a waste of time, so this ends up benefiting us in multiple ways.