feat(win/nvenc): dynamic sdk version selection at runtime#3040
feat(win/nvenc): dynamic sdk version selection at runtime#3040ns6089 wants to merge 1 commit intoLizardByte:masterfrom
Conversation
| "${CMAKE_SOURCE_DIR}/src/nvenc/*.h" | ||
| "${CMAKE_SOURCE_DIR}/src/nvenc/*.cpp") | ||
|
|
||
| include_directories(SYSTEM "${CMAKE_SOURCE_DIR}/third-party/nvenc-headers/12.0/include") |
There was a problem hiding this comment.
| include_directories(SYSTEM "${CMAKE_SOURCE_DIR}/third-party/nvenc-headers/12.0/include") | |
| include_directories(SYSTEM "${CMAKE_SOURCE_DIR}/third-party/nvenc-headers/1200/include") |
Unless I'm missing something, this path doesn't exist.
There was a problem hiding this comment.
Yeah, it used what we ship with ffmpeg in this case. I will think about how to handle this best, either remove these particular headers from windows ffmpeg, or somehow use them (not trivial and may have drawbacks).
There was a problem hiding this comment.
Decided to drop this "default version" logic to minimize potential problems.
One extra version of some classes will be compiled with ffmpeg version of nvenc sdk, but then discarded by the linker.
e6f32a6 to
2ae93f7
Compare
bd4995b to
1e8dd52
Compare
|
Ready. Split-frame encoding will be done in a separate PR since it's a separate feature and we're now auto-squashing commits. |
1e8dd52 to
33991a3
Compare
33991a3 to
e06db26
Compare
|
|
The code in this pull request is Not a Contribution under LizardByte Individual Contributor License Agreement. |
|
Reopening now that the CLA has been revoked and this can now be accepted under the GPLv3 terms alone. |
|
It looks like this PR has been idle for 90 days. If it's still something you're working on or would like to pursue, please leave a comment or update your branch. Otherwise, we'll be closing this PR in 10 days to reduce our backlog. Thanks! |
|
This PR was closed because it has been stalled for 10 days with no activity. |




Description
Notes
nv-codec-headerstonvenc-headersto avoid conflicts during branch switchingTodo
Screenshot
Issues Fixed or Closed
Type of Change
.github/...)Checklist