-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(input): Removed batching of move events of PEN_PACKET #3477
base: master
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- src/input.cpp: Language not supported
When I was testing the the pen support on Windows during initial implementation, I encountered some cases where injecting pen input would take a non-trivial amount of time per event and lead to a massive backlog of input events that caused input latency. Unfortunately, it's not always easy to reproduce (perhaps it depends on the window message processing latency of the focused application). We should probably have some batching to ensure we aren't sending pen events at a completely insane rate that the OS can't keep up with. |
@cgutman Is it possible to make it an option? Users can choose whether to have batching or not. |
It looks like this PR has been idle for 90 days. If it's still something you're working on or would like to pursue, please leave a comment or update your branch. Otherwise, we'll be closing this PR in 10 days to reduce our backlog. Thanks! |
Description
The changes ensure that move events from pens are no longer batched.
This is necessary when Sunshine is used to work with graphics programs.
Issues Fixed
moonlight-stream/moonlight-android#1427
Associated pull requests
moonlight-stream/moonlight-common-c#99
Type of Change
.github/...
)Checklist