Skip to content

fix(config): increase range for min_fps_factor #3715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
momala454 wants to merge 4 commits into from
Closed

fix(config): increase range for min_fps_factor #3715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
692df75
Allow for more min_fps_factor
momala454 Mar 8, 2025
64f18e0
Update DisplayModesSettings.vue
momala454 Mar 8, 2025
8a65916
Update config.cpp
momala454 Mar 8, 2025
705ab5a
Update configuration.md
momala454 Mar 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1382,7 +1382,7 @@ editing the `conf` file in a text editor. Use the examples as reference.
</tr>
<tr>
<td>Range</td>
<td colspan="2">1-3</td>
<td colspan="2">1-30</td>
</tr>
<tr>
<td>Example</td>
Expand Down
2 changes: 1 addition & 1 deletion src/config.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1143,7 +1143,7 @@ namespace config {
video.dd.wa.hdr_toggle_delay = std::chrono::milliseconds {value};
}

int_between_f(vars, "min_fps_factor", video.min_fps_factor, {1, 3});
int_between_f(vars, "min_fps_factor", video.min_fps_factor, {1, 30});
int_f(vars, "max_bitrate", video.max_bitrate);

path_f(vars, "pkey", nvhttp.pkey);
Expand Down
2 changes: 1 addition & 1 deletion src_assets/common/assets/web/configs/tabs/audiovideo/DisplayModesSettings.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const config = ref(props.config)
<!--min_fps_factor-->
<div class="mb-3">
<label for="qp" class="form-label">{{ $t('config.min_fps_factor') }}</label>
<input type="number" min="1" max="3" class="form-control" id="min_fps_factor" placeholder="1" v-model="config.min_fps_factor" />
<input type="number" min="1" max="30" class="form-control" id="min_fps_factor" placeholder="1" v-model="config.min_fps_factor" />
<div class="form-text">{{ $t('config.min_fps_factor_desc') }}</div>
</div>

Expand Down
Loading