Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSOE-864: Adding workflow name, excluding CompatibilitySuppressions files from spell-checking #399

Merged
merged 7 commits into from
Nov 5, 2024
Merged

OSOE-864: Adding workflow name, excluding CompatibilitySuppressions files from spell-checking #399

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
db2d994
Merge branch 'dev' into issue/OSOE-864
Piedone Nov 5, 2024
f2e4906
Adding workflow name
Piedone Nov 5, 2024
673d521
Pointing GHA to issue branch
Piedone Nov 5, 2024
fa1a82e
Excluding CompatibilitySuppressions files from spell-checking
Piedone Nov 5, 2024
bfe5274
Pointing GHA to issue branch
Piedone Nov 5, 2024
0630cdd
Pointing GHA to issue branch
Piedone Nov 5, 2024
2f560fd
Reverting issue branch references for GHA
Piedone Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/spelling/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ runs:
shell: pwsh
run: |
$defaultPrefixes = @{
'lombiq-lgha' = 'https://raw.githubusercontent.com/Lombiq/GitHub-Actions/dev/.github/actions/spelling/'
'lombiq-lgha' = 'https://raw.githubusercontent.com/Lombiq/GitHub-Actions/issue/OSOE-864/.github/actions/spelling/'
'cspell' = 'https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/'
}

Expand Down
3 changes: 2 additions & 1 deletion .github/actions/spelling/excludes.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
\.ttf$
\.woff2$
^\.github/
^LICENSE\.txt$
CompatibilitySuppressions\.xml
ignore$
^LICENSE\.txt$
pnpm-lock\.yaml$
1 change: 1 addition & 0 deletions .github/workflows/publish-nuget.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ on:

jobs:
publish-nuget:
name: Publish to NuGet
runs-on: ubuntu-24.04
timeout-minutes: ${{ inputs.timeout-minutes }}
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/spelling-this-repo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:
jobs:
spelling:
name: Spelling
uses: Lombiq/GitHub-Actions/.github/workflows/spelling.yml@dev
uses: Lombiq/GitHub-Actions/.github/workflows/spelling.yml@issue/OSOE-864
with:
additional-dictionaries: |
cspell:companies/src/companies.txt
4 changes: 2 additions & 2 deletions .github/workflows/spelling.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ jobs:

- name: Check Spelling
id: check-spelling-action
uses: Lombiq/GitHub-Actions/.github/actions/spelling@dev
uses: Lombiq/GitHub-Actions/.github/actions/spelling@issue/OSOE-864
with:
merge-file-excludes: ${{ inputs.merge-file-excludes }}
merge-forbidden-patterns: ${{ inputs.merge-forbidden-patterns }}
Expand All @@ -138,7 +138,7 @@ jobs:
if: always() && needs.check-spelling.outputs.followup && github.event_name == 'pull_request'
steps:
- name: Comment (PR)
uses: Lombiq/GitHub-Actions/.github/actions/spelling@dev
uses: Lombiq/GitHub-Actions/.github/actions/spelling@issue/OSOE-864
with:
post-comment: 1
task: ${{ needs.check-spelling.outputs.followup }}
2 changes: 1 addition & 1 deletion .github/workflows/validate-nuget-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ on:
jobs:
validate-nuget-publish:
name: Validate NuGet Publish
uses: Lombiq/GitHub-Actions/.github/workflows/publish-nuget.yml@dev
uses: Lombiq/GitHub-Actions/.github/workflows/publish-nuget.yml@issue/OSOE-864
with:
cancel-workflow-on-failure: ${{ inputs.cancel-workflow-on-failure }}
verbosity: ${{ inputs.verbosity }}
Expand Down
Loading