Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INFRA-164: GHA/WarpBuild runner OS version pinning #47

Merged
merged 5 commits into from
Oct 31, 2024
Merged

INFRA-164: GHA/WarpBuild runner OS version pinning #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8ba2d87
Upgrading Ubuntu runners to 24.04
BenedekFarkas Oct 17, 2024
ebb6568
Pinning ubuntu-latest to ubuntu-24.04
BenedekFarkas Oct 17, 2024
7642bb4
Pinning Windows runners to 2022
BenedekFarkas Oct 17, 2024
80a6538
Updating static-code-analysis-this-repo to use the issue branch versi…
BenedekFarkas Oct 29, 2024
f28fb3d
Restoring branch references to dev
BenedekFarkas Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/static-code-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ on:
machine-types:
required: false
type: string
default: "['ubuntu-22.04', 'windows-2022']"
default: "['ubuntu-24.04', 'windows-2022']"
description: >
Stringified JSON array with the name of the type of machine(s) to run the workflow under, e.g.
"['ubuntu-22.04']" or "['ubuntu-22.04', 'windows-2022']".
"['ubuntu-24.04']" or "['ubuntu-24.04', 'windows-2022']".
timeout-minutes:
required: false
type: number
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test-analysis-failure.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
name: Test Analysis Failure - NuGet PackageReference
uses: Lombiq/GitHub-Actions/.github/workflows/test-analysis-failure.yml@dev
with:
machine-types: "['ubuntu-latest', 'windows-latest']"
machine-types: "['ubuntu-24.04', 'windows-2022']"
build-directory: TestSolutions/Lombiq.Analyzers.PowerShell.PackageReference
timeout-minutes: 30
build-expected-code-analysis-errors: |
Expand All @@ -38,7 +38,7 @@ jobs:
name: Test Analysis Failure - Local ProjectReference
uses: Lombiq/GitHub-Actions/.github/workflows/test-analysis-failure.yml@dev
with:
machine-types: "['ubuntu-latest', 'windows-latest']"
machine-types: "['ubuntu-24.04', 'windows-2022']"
build-directory: TestSolutions/Lombiq.Analyzers.PowerShell.ProjectReference
timeout-minutes: 30
build-expected-code-analysis-errors: |
Expand Down
2 changes: 1 addition & 1 deletion Readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Do you want to quickly try out this project and see it in action? Check it out i
- You must have [PowerShell 7 or greater installed](https://docs.microsoft.com/en-us/powershell/scripting/install/installing-powershell).
- The _PSScriptAnalyzer_ module must be installed. The script will attempt to auto-install it, however if this fails (e.g. on Windows PowerShell you have to be admin to install modules) follow the steps [here](https://docs.microsoft.com/en-us/powershell/utility-modules/psscriptanalyzer/overview?view=ps-modules#installing-psscriptanalyzer).

Note that if you are using this in GitHub Actions, the common images (`windows-latest` and `ubuntu-latest`) already have these so you don't need to install anything.
Note that if you are using this in GitHub Actions, the common images (`windows-2022` and `ubuntu-24.04`) already have these so you don't need to install anything.

### Usage

Expand Down