Skip to content

Try to get Mongolia to make Skirms#12621

Merged
axatin merged 3 commits intoLoneGazebo:masterfrom
Hokath:skirm-production
Mar 8, 2026
Merged

Try to get Mongolia to make Skirms#12621
axatin merged 3 commits intoLoneGazebo:masterfrom
Hokath:skirm-production

Conversation

@Hokath
Copy link
Contributor

@Hokath Hokath commented Feb 14, 2026

This code was commented out by Ilteroi 4 years ago because all the bonuses were like +5 and didn't matter.

Not sure if it's worth caching any of this, but need to see if it works, first.

Edit: In my first game I'm not seeing Mongolia produce Skirms, still (or anyone else, for that matter...)
Turn 207 (early Renaissance) Karakorum makes 2 heavy skirms back-to-back.
I notice they had a lot of Archers->Comp Bows early, is this happening because Archery units are all treated together?

This code was commented out by Ilteroi 4 years ago because all the bonuses were like +5 and didn't matter.

Not sure if it's worth caching any of this, but need to see if it works, first.
@Hokath
Copy link
Contributor Author

Hokath commented Feb 14, 2026

#8783

@Hokath
Copy link
Contributor Author

Hokath commented Feb 14, 2026

Using @nobubblegums's mod, I do see an occasional Chariot Archer/Skirm, though they haven't got above 2 so far.
So I'm not sure this is the solution by itself.

@Hokath
Copy link
Contributor Author

Hokath commented Feb 14, 2026

Yeah even at a boost of 500, there's no change in behavior.
For whatever reason, this weighting is doing nothing.

I guess the IsPromotionValidForUnitCombatType might evaluate to zero here

@Hokath
Copy link
Contributor Author

Hokath commented Feb 14, 2026

Success!
image

@Hokath
Copy link
Contributor Author

Hokath commented Feb 14, 2026

when the new combat classes are added in #12580
we can move the English Archaeologist to the UnitCombat table, so they won't get this AI weighting -- although it shouldn't matter too much because they already have cap+high weight.

I have added a comment in the new table .xml to signpost that the AI behaves this way to unit classes in the table.

They don't make sense even for the UnitCombat one because they check exactly what the loop has already filtered for
@Hokath Hokath marked this pull request as ready for review February 14, 2026 15:30
@azum4roll
Copy link
Collaborator

Which civs are affected besides Mongolia?

@Hokath
Copy link
Contributor Author

Hokath commented Feb 25, 2026

Atm England (Archaeologist)

@axatin axatin merged commit ef551ad into LoneGazebo:master Mar 8, 2026
10 checks passed
@Hokath Hokath deleted the skirm-production branch March 8, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants