feat: UTD-57: update skeletons and add home tab skeleton #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
When testing the show on map buttons, opening the sheet caused an error where the location's name was undefined when passed into the SheetManager. It seemed like a one time occurrence though since I couldn't recreate it. |
Member
|
@Eric8900 Can you show before/after screenshots or videos? |
Author
|
The skeletons works fine, but the "Show on Map" sometimes throws this error after repeated cycling of "Show on Map" and "More Info." I'll look into it. The video is larger than 10MB, so I'll send it in the discord. |
Razboy20
changed the title
Member
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#122
Added moti skeletons to home tab locations and improved existing skeletons in the location screen