This repository has been archived by the owner on Oct 4, 2024. It is now read-only.
object/names: move name management to libtrx #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rr-
requested review from
lahm86,
walkawayy and
aredfan
and removed request for
a team
|
I found one small issue - Flare is now called |
walkawayy
reviewed
Sep 28, 2024
| { O_COMPASS_ITEM, GF_S_GAME_INV_ITEM_STATISTICS }, | ||
| { O_PISTOL_ITEM, GF_S_GAME_INV_ITEM_PISTOLS }, | ||
| { O_PISTOL_OPTION, GF_S_GAME_INV_ITEM_PISTOLS }, | ||
| { O_FLARE_ITEM, GF_S_GAME_INV_ITEM_FLARE }, |
There was a problem hiding this comment.
I think you forgot an entry for: { O_FLARE_OPTION, ...}, so it falls back to OBJ_NAME_DEFINE(O_FLARES_OPTION, "Flare Option") in libtrx include/libtrx/game/objects/names_tr2.def
rr-
force-pushed
the
libtrx-object-names
branch
from
9374391
to
397a7bc
Compare
|
@aredfan @walkawayy fixed |
walkawayy
approved these changes
Sep 29, 2024
aredfan
approved these changes
Sep 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LostArtefacts/libtrx#39
Affects all item strings in the inventory – keys, passport etc., and all console commands targeting (
/tp dogetc.).