Working on the Header #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my earlier commit I need to convert the App component to a stateful component.
|
Looking like a pretty solid prototype! There's something weird going on in Firefox 59.0.2 for macOS though: |
|
Seeing the same issue on my machine, the menu doesn't show up until I try to close it. |
The issue occurred because of `position: fixed`. I switched it to `absolute` until I can find a permanent fix.
|
It's a little choppy for me, but it's definitely showing the menu now and looking good. Just out of curiosity, what is the plan for this menu? |
|
At some point soon @QuintonJason you should also rebase your branch off of Master so that you have the latest changes from the rest of us. If you keep up with this as you go it will make merging much simpler since you won't get too far out of sync with anything else. |
|
@QuintonJason This does in fact fix the issue for me! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a search and nav toggle. I still need to style it better along with the header bar. Before I went too far in one direction I wanted to post my status.
After I can get this looking nice, I'll split my header into it's own component.