Release of 2.5.1

LucJosin · Oct 19, 2021 · c75f6d4 · c75f6d4
1 parent 36c6574
commit c75f6d4
Show file tree

Hide file tree

Showing 7 changed files with 30 additions and 13 deletions.
diff --git a/on_audio_query/CHANGELOG.md b/on_audio_query/CHANGELOG.md
@@ -1,3 +1,18 @@
+## [2.5.1] - [10.19.2021]
+### Fixes
+#### Dart
+- **[Fixed]** wrong value returning from `[artistId]` when using `[AlbumModel]`. - [#54](https://github.com/LucasPJS/on_audio_query/issues/54)
+
+#### Android
+- **[Fixed]** missing songs from `[queryAudiosFrom]` when using `GENRE`. - [#46](https://github.com/LucasPJS/on_audio_query/issues/46)
+
+### Documentation
+- Updated `README` documentation.
+
+### ⚠ Important Changes
+#### Dart
+- Now `[artistId]` from `[AlbumModel]` return a `[int]`.
+
 ## [2.5.0] - [10.15.2021]
 ### Release
 - `[2.5.0]` release.

diff --git a/on_audio_query/README.md b/on_audio_query/README.md
@@ -63,7 +63,7 @@ NOTE: Feel free to help with readme translations
 Add the following code to your `pubspec.yaml`:
 ```yaml
 dependencies:
-  on_audio_query: ^2.5.0
+  on_audio_query: ^2.5.1
 ```
 
 ### Request Permission:

diff --git a/on_audio_query/README.pt-BR.md b/on_audio_query/README.pt-BR.md
@@ -63,7 +63,7 @@ NOTE: Fique à vontade para ajudar nas traduções
 Adicione o seguinte codigo para seu `pubspec.yaml`:
 ```yaml
 dependencies:
-  on_audio_query: ^2.5.0
+  on_audio_query: ^2.5.1
 ```
 
 #### Solicitar Permissões:

diff --git a/...o_query/android/src/main/kotlin/com/lucasjosino/on_audio_query/query/OnAudiosFromQuery.kt b/...o_query/android/src/main/kotlin/com/lucasjosino/on_audio_query/query/OnAudiosFromQuery.kt
@@ -107,7 +107,6 @@ class OnAudiosFromQuery : ViewModel() {
     //Loading in Background
     private suspend fun loadSongsFrom(): ArrayList<MutableMap<String, Any?>> =
         withContext(Dispatchers.IO) {
-            // TODO: Add a [sortType].
             // Setup the cursor with [uri], [projection], [selection](where) and [values](whereVal).
             val cursor = resolver.query(uri, songProjection(), where, arrayOf(whereVal), sortType)
             // Empty list.
@@ -125,6 +124,7 @@ class OnAudiosFromQuery : ViewModel() {
                 val tempExtraData = helper.loadSongExtraInfo(uri, tempData)
                 tempData.putAll(tempExtraData)
 
+                //
                 songsFromList.add(tempData)
             }
 

diff --git a/...uery/android/src/main/kotlin/com/lucasjosino/on_audio_query/query/helper/OnAudioHelper.kt b/...uery/android/src/main/kotlin/com/lucasjosino/on_audio_query/query/helper/OnAudioHelper.kt
@@ -55,7 +55,8 @@ class OnAudioHelper {
     //This method will separate [String] from [Int]
     fun loadAlbumItem(itemProperty: String, cursor: Cursor): Any? {
         return when (itemProperty) {
-            "_id" -> {
+            "_id", 
+            "artist_id" -> {
                 // The [album] id from Android >= 30/R is a [Long] instead of [Int].
                 if (Build.VERSION.SDK_INT >= 30) {
                     cursor.getLong(cursor.getColumnIndex(itemProperty))

diff --git a/...udio_query/android/src/main/kotlin/com/lucasjosino/on_audio_query/types/AudiosFromType.kt b/...udio_query/android/src/main/kotlin/com/lucasjosino/on_audio_query/types/AudiosFromType.kt
@@ -6,12 +6,13 @@ import android.provider.MediaStore
 @SuppressLint("InlinedApi")
 fun checkAudiosFromType(sortType: Int): String {
     return when (sortType) {
-        0 -> MediaStore.Audio.Media.ALBUM + "=?"
-        1 -> MediaStore.Audio.Media.ALBUM_ID + "=?"
-        2 -> MediaStore.Audio.Media.ARTIST + "=?"
-        3 -> MediaStore.Audio.Media.ARTIST_ID + "=?"
-        4 -> MediaStore.Audio.Media.GENRE + "=?"
-        5 -> MediaStore.Audio.Media.GENRE_ID + "=?"
+        0 -> MediaStore.Audio.Media.ALBUM + " like ?"
+        1 -> MediaStore.Audio.Media.ALBUM_ID + " like ?"
+        2 -> MediaStore.Audio.Media.ARTIST + " like ?"
+        3 -> MediaStore.Audio.Media.ARTIST_ID + " like ?"
+        // Use the [TRIM] to remove all empty space from genre name.
+        4 -> "TRIM(\"" + MediaStore.Audio.Media.GENRE + "\")" + " like ?"
+        5 -> MediaStore.Audio.Media.GENRE_ID + " like ?"
         else -> throw Exception("[checkAudiosFromType] value don't exist!")
     }
 }
diff --git a/on_audio_query/pubspec.yaml b/on_audio_query/pubspec.yaml
@@ -1,6 +1,6 @@
 name: on_audio_query
 description: Flutter Plugin used to query audios/songs infos [title, artist, album, etc..] from device storage.
-version: 2.5.0
+version: 2.5.1
 homepage: https://github.com/LucasPJS/on_audio_query/tree/main/on_audio_query
 # pub.dev: https://pub.dev/packages/on_audio_query
 # ========
@@ -14,8 +14,8 @@ environment:
 
 dependencies:
   # on_audio_query
-  on_audio_query_platform_interface: ^1.3.0
-  on_audio_query_web: ^1.3.1
+  on_audio_query_platform_interface: ^1.3.1
+  on_audio_query_web: ^1.3.2
 
   # Flutter
   flutter: