Skip to content

Yoton Y3 projector #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

fiveangle
Copy link

Projectors/BrandUknown/Generic_Projector.ir matched the remote I pulled with my F0 from my Yoton Y3 mini projector with exception of one extra button, so renamed original w/code comment outlier button

Copy link

Thank you for your contribution! ❤️

The linter found no issues. 🎉

@darmiel
Copy link
Collaborator

darmiel commented Apr 12, 2025

The Generic_Projector file is meant to stay generic so it can apply to different devices - would you mind creating a new file for your projector instead? 🙂

@darmiel darmiel added the pending Waiting for Author label Apr 12, 2025
@fiveangle
Copy link
Author

This is so confusing. If all these profiles truly came from devices with zero branding on them and not from branded devices that were not provided when you obtained them, wouldn't it make more sense to rename this dir to "Unbranded" and then rename every profile in it with the consistent name "Unbranded_[device class]-[index].ir" where 'index' is an arbitrarily assigned ascending integer beginning at "1" ?

That way users will understand exactly what the profile is suppose to be.

"Unknown Brand" implies a brand for the device that generated the profile exists but is not known [yet] and users are challenged to try and identity the brand.

Regardless, either way, I agree that since at least one command in this profile was different than mine, a new profile for my Yoton projector capture is the correct action.

Please consider the restructuring suggestion, because as it is now, the directory appears a challenge to the community to help identity the brand for these profiles, but there's no sense anyone wasting time to do so when they are from unbranded devices 😄

I'll rebase the pr in the next couple days or so.

Thanks for clarifying the purpose of these profiles for me !

-=dave

@fiveangle fiveangle force-pushed the yoton-y3-projector branch from f9f0c97 to d66cfd8 Compare May 8, 2025 03:35
Commands found to be very similar to: ‎Projectors/BrandUnknown/Generic_Projector.ir
@fiveangle fiveangle force-pushed the yoton-y3-projector branch from d66cfd8 to f5eef38 Compare May 8, 2025 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending Waiting for Author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants