Test and improve the synchronization code #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ----- * Add tests to bring `Synchronization.py` to 100% coverage * Add type annotations to the synchronization primitives * Add `typing_extensions` as a Python 3.9 requirement; this is needed to annotate that the `synchronized()` decorator takes a function with a certain set of parameter and return types and returns a function with the same parameter and return types Changed ------- * Make the synchronized function's `self` parameter explicit; this allows the `self` parameter to be type-annotated so the dependency on the `self.mutex` attribute is explicit * Use the `self.mutex` lock as a context manager * Support keyword arguments to synchronized functions Fixed ----- * Wrap synchronized functions correctly; previous behavior was to lose the function name and docstring Removed ------- * Remove `print()` lines that are commented out * Remove a `bytes` instance check; method names can only be strings
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Synchronization.pyto 100% coveragetyping_extensionsas a Python 3.9 requirement; this is needed to annotate that thesynchronized()decorator takes a function with a certain set of parameter and return types and returns a function with the same parameter and return typesChanged
selfparameter explicit; this allows theselfparameter to be type-annotated so the dependency on theself.mutexattribute is explicitself.mutexlock as a context managerFixed
Removed
print()lines that are commented outbytesinstance check; method names can only be strings