Skip to content

Removes the arkenfox-auto-update script #1442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

aartoni
Copy link
Contributor

@aartoni aartoni commented Nov 9, 2024

According to the findings in #1439, the arkenfox-auto-update script is neither working nor needed. Closes #1439.

@aartoni
Copy link
Contributor Author

aartoni commented Nov 9, 2024

There's a companion PR that should be merged first to avoid broken LARBS deployments.

@BEST8OY
Copy link

BEST8OY commented Nov 14, 2024

@aartoni
What do you think on triggering the script on arkenfox-user.js-git and arkenfox-user.js instead of deleting it altogether?

@aartoni
Copy link
Contributor Author

aartoni commented Nov 16, 2024

I'd prefer the hook to ship with the packages you've mentioned. I'm trying to get in touch with the packager for that.

I believe that this makes sense because if I'm having pacman handling the user.js for me, then I also want it to keep it up to date. @BEST8OY What do you think?

@BEST8OY
Copy link

BEST8OY commented Nov 16, 2024

What do you think?

That would be the ideal way.

@LukeSmithxyz LukeSmithxyz merged commit 21c0122 into LukeSmithxyz:master Feb 28, 2025
@aartoni aartoni deleted the fix/unnecessary-arkenfox-hook branch March 1, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete Arkenfox script hook
3 participants