Skip to content

Create maven.yml #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions .github/workflows/maven.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
# This workflow will build a Java project with Maven, and cache/restore any dependencies to improve the workflow execution time
# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-java-with-maven

# This workflow uses actions that are not certified by GitHub.
# They are provided by a third-party and are governed by
# separate terms of service, privacy policy, and support
# documentation.

name: Java CI with Maven

on:
push:
branches: [ "master" ]
pull_request:
branches: [ "master" ]

jobs:
build:

runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4
- name: Set up JDK 11
uses: actions/setup-java@v4
with:
java-version: '11'
distribution: 'temurin'
cache: maven
- name: Build with Maven
run: mvn -B package --file pom.xml -DversionHash=$(git rev-parse --short HEAD)

# Optional: Uploads the full dependency graph to GitHub to improve the quality of Dependabot alerts this repository can receive
- name: Update dependency graph
uses: advanced-security/maven-dependency-submission-action@571e99aab1055c2e71a1e2309b9691de18d6b7d6
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,31 @@
public class ReferenceNotFoundException extends NoSuchElementException {
private static final long serialVersionUID = -4277935098528086486L;

private String reference;
private IAsap2TreeElement source;
private List<String> indexes;
private final String reference;
private final IAsap2TreeElement source;
private final List<String> indexes;

public ReferenceNotFoundException(String referenceString, IAsap2TreeElement node, List<String> searchedIndexes) {
this.reference = referenceString;
this.source = node;
this.indexes = searchedIndexes;
}

public String getReference() {
return reference;
}

public IAsap2TreeElement getSource() {
return source;
}

public List<String> getIndexes() {
return indexes;
}

@Override
public String toString() {
return String.format("Cannot find reference '%s' of '%s' in index '%s'", reference, source.toString(),
return String.format("Cannot find reference '%s' of '%s' in index(es) '%s'", reference, source.toString(),
String.join(",", indexes));
}
}
6 changes: 1 addition & 5 deletions src/main/java/net/alenzen/a2l/indexes/ReferenceResolver.java
Original file line number Diff line number Diff line change
Expand Up @@ -146,12 +146,8 @@ private void resolveReferencesOnFields(IAsap2TreeElement node, Map<String, Map<S
}

if (!referenceFoundFlag) {
new ReferenceNotFoundException(referenceString, node, searchedIndexes);
referenceNotFound.accept( // TODO improve exception so the exception contains the actual data to
// better debug and filter issues
new NoSuchElementException());
referenceNotFound.accept(new ReferenceNotFoundException(referenceString, node, searchedIndexes));
}

}

// loop exit condition
Expand Down
Loading