Laravel 10 #14
Merged
Laravel 10 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albinhallen
force-pushed
the
laravel-10
branch
from
dbd12a4 to
c9b9e76
Compare
|
Tested locally and can verify the following works:
Unverified stuff:
|
albinhallen
commented
Oct 7, 2024
| - name: Static analysis | ||
| run: vendor/bin/phpstan --memory-limit=512M analyze | ||
|
|
||
| - name: Migrate phpunit schema |
There was a problem hiding this comment.
When running dependency-version: [prefer-lowest, prefer-stable], the versions don't use the same schema so need to migrate it before running
TestsSent from
|
|
Based on this guide on maintenance branches, we should create the |
albinhallen
force-pushed
the
laravel-10
branch
5 times, most recently
from
441134e to
e14bcb4
Compare
adamczykpiotr
previously approved these changes
Oct 8, 2024
BREAKING CHANGE: Requires Laravel v10 or above fix: phpstan ignore mocks fix: add missing package test: add test with attachments included ci: only run supported versions of php chore: clean up fix: change method to set attachment headers ci: change phpunit schema in runtime fix: fix typing fix: include phpunit and phpstan in composer.json ci: update workflow build: basic docker compose for local development feat: Laravel 10 compatability
albinhallen
force-pushed
the
laravel-10
branch
from
e14bcb4 to
906b14f
Compare
albinhallen
dismissed
adamczykpiotr’s stale review
The base branch was changed.
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo
Create new branch
v2where this should merge to