fix(markdown/text-editor): properly handle internal vs external link targets

[FredrikWallstrom]

Fixes https://github.com/Lundalogik/crm-feature/issues/4397

@coderabbitai summary

How to Test

1. Open the Rich Text Editor

   • Create internal links (same domain/relative urls)
   • Create external links (different domains)
   • Verify internal links don't have target="_blank"
   • Verify external links have target="_blank" and security attributes

2. Check Markdown Component

   • Add markdown with internal links
   • Add markdown with external links
   • Verify the same behavior as in Rich Text Editor

Expected Results

• Internal links stay in the same tab (no target="_blank")
• External links open in new tabs (with target="_blank")
• Security attributes (rel="noopener noreferrer", referrerpolicy="noreferrer") are present on external links
• No regressions in link functionality or appearance should be observed.

Review:

• Commits are atomic
• Commits have the correct type for the changes made
• Commits with breaking changes are marked as such

Browsers tested:

(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)

Windows:

• Chrome
• Edge
• Firefox

Linux:

• Chrome
• Firefox

macOS:

• Chrome
• Firefox
• Safari

Mobile:

• Chrome on Android
• iOS

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

The changes introduce a custom link attribute handling system, replacing the external rehype-external-links dependency. A utility function centralizes logic for determining link attributes based on whether a URL is internal or external. The ProseMirror editor's link mark specification and schema are updated to support these attributes, ensuring consistent link behavior and security across the application.

Changes

File(s)	Change Summary
package.json	Removed the rehype-external-links dependency from devDependencies.
src/components/markdown/link-markdown-plugin.ts	Added a new unified.js plugin (createLinksPlugin) to traverse Markdown AST, enhancing <a> elements with security and behavior-related attributes using the new utility function.
src/components/markdown/markdown-parser.ts	Replaced rehype-external-links with the custom createLinksPlugin in the Markdown processing pipeline. Updated sanitization whitelist to allow the referrerpolicy attribute on <a> tags.
src/components/text-editor/prosemirror-adapter/menu/menu-commands.ts src/design-guidelines/...	Refactored link insertion command to use the new getLinkAttributes utility, centralizing logic for link attributes and reducing code duplication.
src/components/text-editor/prosemirror-adapter/plugins/link/utils.ts	Introduced a utility module with the getLinkAttributes function. This determines link attributes (like target, rel, referrerpolicy) based on whether a URL is internal or external, using robust URL parsing.
src/components/text-editor/prosemirror-adapter/plugins/link/link-mark-spec.ts	Added a new ProseMirror link mark specification (linkMarkSpec) supporting extended attributes (target, rel, referrerpolicy). Included logic to inject security attributes for external links.
src/components/text-editor/prosemirror-adapter/plugins/link/link-plugin.ts	Refactored to use the new getLinkAttributes utility in link node creation, centralizing attribute logic and removing inline conditional handling. Updated import statements accordingly.
src/components/text-editor/prosemirror-adapter/prosemirror-adapter.tsx	Updated imports to use the new link plugin and mark spec. Integrated the new link mark specification into the ProseMirror schema initialization, enabling support for the extended link attributes.

Sequence Diagram(s)

sequenceDiagram
    participant MarkdownParser
    participant createLinksPlugin
    participant getLinkAttributes

    MarkdownParser->>createLinksPlugin: Process Markdown AST
    createLinksPlugin->>getLinkAttributes: For each <a href="...">
    getLinkAttributes-->>createLinksPlugin: Return attributes (target, rel, referrerpolicy, etc.)
    createLinksPlugin-->>MarkdownParser: Return transformed AST with enhanced links

Loading

sequenceDiagram
    participant ProseMirrorEditor
    participant getLinkAttributes
    participant linkMarkSpec

    ProseMirrorEditor->>getLinkAttributes: On link insertion (with URL)
    getLinkAttributes-->>ProseMirrorEditor: Return link attributes
    ProseMirrorEditor->>linkMarkSpec: Create link mark with attributes
    linkMarkSpec-->>ProseMirrorEditor: Link mark with correct security attributes

Loading

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3563/

[FredrikWallstrom]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.