Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix diagnostics not being complete on version 6 #2892

Merged
merged 6 commits into from
Jan 11, 2025
Merged

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jan 10, 2025

Some info were incomplete due to formatting...
Solved with some refactoring to later allow discarding messages.

@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Jan 10, 2025
@ildyria ildyria requested a review from d7415 January 10, 2025 19:28
@ildyria ildyria added this to the 6.3 milestone Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 61.42857% with 27 lines in your changes missing coverage. Please review.

Project coverage is 84.03%. Comparing base (4258b84) to head (a6573e6).
Report is 2 commits behind head on master.

Additional details and impacted files

@ildyria ildyria changed the title fix diagnostics not being complete Fix diagnostics not being complete on version 6 Jan 11, 2025
@ildyria ildyria merged commit 18d2de7 into master Jan 11, 2025
52 checks passed
@ildyria ildyria deleted the improve-diagnostics branch January 11, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants