Allow to edit taken_at date #2954
Conversation
ildyria
added
the
Review: easy
|
After further thoughts, this is not the fully correct approach. There is one problem: the set taken_at date does not will not be considered for sorting etc. This somewhat defeats the purpose of the functionality. I considered using taken_at_mod to store the original taken at date, but unfortunately changing the date twice would make this old non-existing date (null) gone. Considering a third approach would require both taken_at_origin and a boolean is_exif_taken_at... |
Fixed. |
ildyria
force-pushed
the
allow-edit-camera-date
branch
from
e65664c to
ac89779
Compare
| const takenDate = (photo.taken_at ?? "").slice(0, 16); | ||
| takenAtTz.value = (photo.taken_at ?? "").slice(16); |
There was a problem hiding this comment.
should it be slice(0,19) instead? Date format is of type 2021-01-01T00:00:00+00:00 as I understood. And the timezone information is starting at "+" character which is at 19th character location.
| const dataDate = (photo.created_at ?? "").slice(0, 16); | ||
| uploadTz.value = (photo.created_at ?? "").slice(16); |
There was a problem hiding this comment.
should it be slice(0,19) instead? Date format is of type 2021-01-01T00:00:00+00:00 as I understood. And the timezone information is starting at "+" character which is at 19th character location.
| const takenDate = takenAtDate.value === undefined ? null : takenAtDate.value.toISOString().slice(0, 16) + takenAtTz.value; | ||
|
|
|
Looking good and user friendly! 🙂 |
by popular demand.
Fixes #2537