Front-end for timeline page #3252

ildyria · 2025-04-18T14:38:30Z

This pull request includes several changes aimed at improving naming consistency, enhancing timeline handling, and introducing new features like a timeline date navigation component. Below is a summary of the most important changes grouped by theme:

Naming Consistency Improvements:

Updated albumid to albumId across multiple files to ensure consistent camelCase naming conventions, including in Unlock.vue, ShareLine.vue, and AlbumThumb.vue. [1] [2] [3] [4]

Timeline and Layout Enhancements:

Added a new TimelineDates.vue component for navigating timeline dates, including logic for highlighting the current date and year.
Refactored timeline-related properties such as isTimeline and is_timeline_left_border_visible to computed properties for better reactivity and maintainability in components like PhotoThumbPanel.vue and AlbumThumbPanel.vue. [1] [2] [3] [4]
Updated PhotoThumbPanelList.vue to use idx instead of iter for unique identification of photo listings. [1] [2] [3]

Navigation and Routing Updates:

Simplified photo navigation by removing the albumId parameter from routes in AlbumPanel.vue, NextPrevious.vue, and ResultPanel.vue. [1] [2] [3]
Added a photoClick method in ResultPanel.vue to handle photo navigation using the updated route structure.

Feature Toggles:

Introduced an is_favourite_enabled toggle to conditionally display the "Favourites" link in AlbumHeader.vue and AlbumsHeader.vue. [1] [2] [3]

UI and Interaction Improvements:

Enhanced the Dock.vue component by conditionally displaying the "Set Album Header" button based on the isTimeline property. [1] [2]
Adjusted z-index and layout styles in PhotoPanel.vue for better slideshow and photo header rendering.

codecov · 2025-04-21T18:46:32Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.44%. Comparing base (08bf005) to head (34606ab).

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

JasonMillward · 2025-06-08T00:11:28Z

resources/js/components/headers/TimelineHeader.vue

+//  'UPLOAD_PHOTO' => 'Upload Photo',
+// 	'IMPORT_LINK' => 'Import from Link',
+// 	'IMPORT_DROPBOX' => 'Import from Dropbox',
+// 	'IMPORT_SERVER' => 'Import from Server',
+// 	'NEW_ALBUM' => 'New Album',
+// 	'NEW_TAG_ALBUM' => 'New Tag Album',
+// 	'UPLOAD_TRACK' => 'Upload track',
+// 	'DELETE_TRACK' => 'Delete track',


If this comment is required could it be tidied up and expanded on

Fixed : 82d7b3d

JasonMillward · 2025-06-08T00:12:46Z

resources/js/composables/selections/selections.ts

+		console.log("CTRL", idx);
 		if (isPhotoSelected(idx)) {
+			console.log("REMOVE");
 			removeFromPhotoSelection(idx);
 		} else {
+			console.log("ADD");
 			addToPhotoSelection(idx);
 		}
 		lastPhotoClicked.value = idx;
 	}

 	function handlePhotoShift(idx: number, e: Event): void {
+		console.log("SHIFT", idx);


Are the console logs meant to be here?

Fixed : 82d7b3d

JasonMillward · 2025-06-08T00:13:04Z

resources/js/composables/timeline/routeDateUpdater.ts

+			const startAt = section.getBoundingClientRect().top + currentPosition;
+			const endAt = startAt + section.offsetHeight;
+			const isInView = currentPosition >= startAt && currentPosition < endAt;
+			console.log("Sections", section.dataset.date, isInView);


Fixed : 82d7b3d

ildyria · 2025-06-12T08:30:15Z

resources/js/composables/contextMenus/leftMenu.ts

 				route: "/frame",
+				access: !(route.name as string).includes("frame") && (initData.value.modules.is_mod_frame_enabled ?? false),


unnecessary route check. frame has only a goBack button.

ildyria · 2025-06-12T08:31:03Z

resources/js/composables/album/uploadEvents.ts

@@ -20,7 +20,6 @@ export function useMouseEvents(
 	}

 	function dropUpload(e: DragEvent) {
-		// console.log("dropUpload");


extract to another PR.

ildyria · 2025-06-12T08:31:21Z

resources/js/components/headers/AlbumsHeader.vue

@@ -7,17 +7,6 @@
 		:pt:center:class="'absolute top-0 py-3 left-1/2 -translate-x-1/2 h-14'"
 	>
 		<template #start>
-			<!-- Not logged in. -->


extract to another pr

ildyria requested a review from a team as a code owner April 18, 2025 14:38

ildyria marked this pull request as draft April 18, 2025 17:12

ildyria force-pushed the frontend-timeline branch from ea52a7d to c5dbc65 Compare April 21, 2025 18:36

ildyria force-pushed the backend-timeline branch from 172b60c to 751207d Compare April 21, 2025 18:36

ildyria force-pushed the frontend-timeline branch from c5dbc65 to 812fe55 Compare April 22, 2025 16:21

ildyria changed the title ~~Front-end for timeline page~~ 🚧 Front-end for timeline page Apr 22, 2025

ildyria added the parked - will revisit later This PR needs more work but some things need to be fixed before. label Apr 23, 2025

ildyria force-pushed the frontend-timeline branch from 812fe55 to 91ae020 Compare May 27, 2025 15:15

ildyria force-pushed the backend-timeline branch from 97fcc72 to 5458450 Compare May 27, 2025 15:15

ildyria force-pushed the frontend-timeline branch 3 times, most recently from 77e6da3 to 45d9efe Compare May 28, 2025 16:28

ildyria force-pushed the backend-timeline branch from 2c45144 to 86f46d4 Compare May 28, 2025 16:28

ildyria force-pushed the frontend-timeline branch from 45d9efe to b50b1b4 Compare May 28, 2025 16:43

ildyria force-pushed the backend-timeline branch 2 times, most recently from 79c16fe to 002a68e Compare May 28, 2025 18:27

ildyria force-pushed the frontend-timeline branch from b50b1b4 to 0d7e38f Compare May 28, 2025 18:28

ildyria force-pushed the backend-timeline branch from 002a68e to 9814f19 Compare May 28, 2025 18:33

ildyria force-pushed the frontend-timeline branch from 0d7e38f to 7d8f9be Compare May 28, 2025 18:33

ildyria removed the parked - will revisit later This PR needs more work but some things need to be fixed before. label May 28, 2025

ildyria marked this pull request as ready for review May 29, 2025 12:43

ildyria changed the title ~~🚧 Front-end for timeline page~~ Front-end for timeline page May 29, 2025

ildyria added the Review: medium Medium review expected: not many files, some attention to details required. label May 29, 2025

ildyria force-pushed the backend-timeline branch from 8ac37d8 to b89975e Compare May 29, 2025 16:39

ildyria force-pushed the frontend-timeline branch 2 times, most recently from 1625125 to d3dce6f Compare May 29, 2025 16:43

JasonMillward reviewed Jun 8, 2025

View reviewed changes

ildyria force-pushed the frontend-timeline branch 2 times, most recently from e3f323a to 56cc6a1 Compare June 8, 2025 08:51

ildyria force-pushed the backend-timeline branch from e5e533d to 7198efb Compare June 8, 2025 08:54

ildyria force-pushed the frontend-timeline branch from ab7c255 to 50806d4 Compare June 8, 2025 09:50

ildyria force-pushed the backend-timeline branch from 7198efb to 00c717b Compare June 8, 2025 09:51

ildyria force-pushed the frontend-timeline branch from 50806d4 to 42ddf39 Compare June 8, 2025 10:19

ildyria force-pushed the backend-timeline branch from 6eefc2a to 6829366 Compare June 11, 2025 13:07

ildyria force-pushed the frontend-timeline branch from 42ddf39 to e739480 Compare June 11, 2025 13:07

squash

34606ab

ildyria force-pushed the frontend-timeline branch from e739480 to 34606ab Compare June 11, 2025 13:45

ildyria force-pushed the backend-timeline branch from 6829366 to 08bf005 Compare June 11, 2025 13:45

ildyria commented Jun 12, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Front-end for timeline page #3252

Front-end for timeline page #3252

Uh oh!

ildyria commented Apr 18, 2025

Uh oh!

codecov bot commented Apr 21, 2025 •

edited

Loading

Uh oh!

JasonMillward Jun 8, 2025

Uh oh!

ildyria Jun 8, 2025

Uh oh!

ildyria Jun 8, 2025

Uh oh!

JasonMillward Jun 8, 2025

Uh oh!

ildyria Jun 8, 2025

Uh oh!

ildyria Jun 8, 2025

Uh oh!

JasonMillward Jun 8, 2025

Uh oh!

ildyria Jun 8, 2025

Uh oh!

ildyria Jun 8, 2025

Uh oh!

ildyria Jun 12, 2025

Uh oh!

ildyria Jun 12, 2025

Uh oh!

ildyria Jun 12, 2025

Uh oh!

Uh oh!

		route: "/frame",
		access: !(route.name as string).includes("frame") && (initData.value.modules.is_mod_frame_enabled ?? false),

Uh oh!

Front-end for timeline page #3252

Are you sure you want to change the base?

Front-end for timeline page #3252

Uh oh!

Conversation

ildyria commented Apr 18, 2025

Naming Consistency Improvements:

Timeline and Layout Enhancements:

Navigation and Routing Updates:

Feature Toggles:

UI and Interaction Improvements:

Uh oh!

codecov bot commented Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Apr 21, 2025 •

edited

Loading