Skip to content

Add user-group permissions to query #3425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jun 9, 2025

This pull request introduces enhancements to user group management and access permission handling. Key changes include the addition of constants for user group attributes, modifications to access permission queries to incorporate user group-based permissions, and updates to ensure proper verification of feature availability.

User Group Management Enhancements:

Access Permission Handling:

  • app/Policies/AlbumQueryPolicy.php: Updated the getComputedAccessPermissionSubQuery method to include user group-based permissions in access queries. This ensures permissions can be evaluated based on both individual users and their associated user groups.

Feature Verification Updates:

Namespace Additions:

Dependency Inclusion:

Copy link

codecov bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.76%. Comparing base (8562bdb) to head (2fcba76).

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Jun 9, 2025
@ildyria ildyria marked this pull request as ready for review June 9, 2025 21:36
@ildyria ildyria requested a review from a team as a code owner June 9, 2025 21:36
@ildyria ildyria force-pushed the user-groups/permissions branch from f5dc9d0 to 3756aa0 Compare June 11, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant