Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package installs update #341

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Package installs update #341

merged 3 commits into from
Oct 5, 2023

Conversation

grallewellyn
Copy link
Contributor

@grallewellyn grallewellyn commented Sep 27, 2023 •
edited
Loading

Since we changed base images to use libmamba solver with conda install instead of mamba, updated docs to recommend installing everything with conda install -c conda-forge

Tested all commands listed

Also, fixes Respository typo

References: MAAP-Project/Community#731 (comment)

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

wildintellect
wildintellect reviewed Sep 28, 2023
View reviewed changes
docs/source/getting_started/writing_code.ipynb Show resolved Hide resolved
docs/source/system_reference_guide/custom-environments.ipynb
@@ -38,27 +38,33 @@
"\n",
Copy link
Collaborator

@wildintellect wildintellect Sep 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bold or italicize libmamba

use a callout box to talk about libmamba

> Note:
text

Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wildintellect I agree with bold or italicize libmamba, but how would you suggest I change the line:
"We use conda with the libmamba solver as a package manager to install, update or remove packages (libraries)."? libmamba is in a callout box even when it is in the middle of the sentence?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the callout box should be after the sentence explaining what libmamba is and how you can use classic if you want/need

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So conda install --solver=classic -c conda-forge xarray is in the callout box?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wildintellect Just following up on the above comment

@wildintellect wildintellect self-requested a review October 5, 2023 21:32
@grallewellyn grallewellyn merged commit ecba636 into develop Oct 5, 2023
@grallewellyn grallewellyn deleted the package-installs-update branch October 18, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wildintellect wildintellect wildintellect approved these changes

@rtapella rtapella Awaiting requested review from rtapella

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grallewellyn @wildintellect @rtapella