Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dps tutorial v1 #389

Merged
merged 45 commits into from
Apr 8, 2024
Merged

Dps tutorial v1 #389

merged 45 commits into from
Apr 8, 2024

Conversation

rtapella
Copy link
Collaborator

Initial version of the DPS in-depth tutorial:

  • example DPS tutorial repository
  • cover all the steps from writing your algorithm to running it in DPS
  • initial version covers the GUI-based registration and execution

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -0,0 +1,559 @@
{
Copy link
Contributor

@omshinde omshinde Mar 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • sets the correct python environment for your code to run
  • the best way to execute your algorithm with a custom environment is to use conda run, as shown in this script(conda run --live-stream --name dps_tutorial python ${basedir}/gdal_wrapper.py --input_file ${INPUT_FILENAME} --output_file output/${OUTPUT_FILENAME} --outsize ${REDUCTION_SIZE}
  • )

)

Do we need this ) to be a separate bullet point?


Reply via ReviewNB

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm I do not see that extra bullet point in my browser...

@@ -0,0 +1,559 @@
{
Copy link
Contributor

@omshinde omshinde Mar 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a minor formatting suggestion but it looks nice to start a sentence with Uppercase.


Reply via ReviewNB

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed a fix for uppercasing those bullets

@omshinde
Copy link
Contributor

This looks good to me. I suggested some minor changes. Also, it seems that there's a TODO section towards the end of the notebook. Otherwise, nice work.

@rtapella
Copy link
Collaborator Author

rtapella commented Apr 8, 2024

also removed the TODO section
please check again @omshinde

@omshinde omshinde self-requested a review April 8, 2024 19:21
Copy link
Contributor

@omshinde omshinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rtapella .. The revisions look good to me.

@rtapella rtapella merged commit a9f09d7 into develop Apr 8, 2024
@rtapella rtapella deleted the dps-tutorial-v1 branch April 8, 2024 20:12
@rtapella
Copy link
Collaborator Author

resolves #278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants