-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dps tutorial v1 #389
Dps tutorial v1 #389
Conversation
- also cleaned up some broken links in other pages
The 3.1.4 workspace is when the aws cli is installed by default, to download the example data from s3
clarify command-line run
- interleaved instructions - updated images
- swap "input" image vs. instruction - put some code/script names into code format
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@@ -0,0 +1,559 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- sets the correct python environment for your code to run
- the best way to execute your algorithm with a custom environment is to use
conda run
, as shown in this script(conda run --live-stream --name dps_tutorial python ${basedir}/gdal_wrapper.py --input_file ${INPUT_FILENAME} --output_file output/${OUTPUT_FILENAME} --outsize ${REDUCTION_SIZE}
- )
)
Do we need this )
to be a separate bullet point?
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm I do not see that extra bullet point in my browser...
@@ -0,0 +1,559 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably a minor formatting suggestion but it looks nice to start a sentence with Uppercase.
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pushed a fix for uppercasing those bullets
This looks good to me. I suggested some minor changes. Also, it seems that there's a TODO section towards the end of the notebook. Otherwise, nice work. |
- updated basedir command to be more cross-platform friendly
also removed the TODO section |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @rtapella .. The revisions look good to me.
resolves #278 |
Initial version of the DPS in-depth tutorial: