-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sdg23 add contribute page #446
base: master
Are you sure you want to change the base?
Sdg23 add contribute page #446
Conversation
Add contribute page Add contribute page
…e-page-md merged master into sdg23-add-contribute-page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! looking good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this page needs to make clear that there's much more to the MDAnalysis Project than just the core library and the User Guide. Please see comments & please ask here (and in discord) if you want to bounce ideas.
Thanks @micaela-matta, @orbeckst and @RMeli for your comments. I redesigned the page based on your suggestions. |
Thanks @micaela-matta for your last comments. I've incorporated the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rewrite is really nice.
My remaining concerns are
- We should mention that we have other code repos that are not MDAKits and there contributors are also welcome.
- I am hesitant to include content in this page that needs updating. Someone has to (1) do it regularly (nobody does), (2)has to remember that content needs to be updated here (eg for GSoC, events). And when things are not being updated, the page feels stale sooner than strictly necessary. If there's a way to automate inclusion of content (e.g., based on tags in the meta data) then that would be neat, though.
Thanks @micaela-matta for your comments. I've updated the page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all looking very good. I have a bunch of suggestions and one technical request: use post_url
liquid tags when referencing blog posts. This is necessary to generate reliably stable links.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @namiroues - some last minor changes from me
Thanks @micaela-matta. I've made the changes. |
This PR addresses #441.