Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed okwarning block warning #389

Merged
merged 7 commits into from
Mar 24, 2025
Merged

Fixed okwarning block warning #389

merged 7 commits into from
Mar 24, 2025

Conversation

mhmohona
Copy link
Contributor

@mhmohona mhmohona commented Oct 13, 2024 •
edited by orbeckst
Loading

Fixed okwarning block warning
Ignored DCDReader currently makes independent timesteps warning.

Closes #378

📚 Documentation preview 📚: https://mdanalysisuserguide--389.org.readthedocs.build/en/389/

@RMeli
Copy link
Member

RMeli commented Oct 14, 2024

@mhmohona if you write "Close #378" instead of "Closes - #378" the issue will automatically close when the PR is merged, which is useful.

RMeli
RMeli reviewed Oct 14, 2024
View reviewed changes
orbeckst
orbeckst requested changes Dec 18, 2024
View reviewed changes
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this issue — really much appreciated.

Could you please try to solve the issue with only using sphinx directives? Hopefully, no Python code is needed.

@orbeckst orbeckst self-assigned this Dec 18, 2024
@orbeckst
Copy link
Member

Can you please merge the current develop branch into this one here? This should make the mda_gh_ci_tests / examples-tests (pull_request) pass.

Did you check if :suppress: works?

@orbeckst
Copy link
Member

Can you please also edit your original PR comment following #389 (comment) so that it will automatically close the related issue? Thanks.

@orbeckst orbeckst linked an issue Dec 19, 2024 that may be closed by this pull request
Specify :okwarning: as an option in the ipython:: block to suppress a warning #378
Closed
@orbeckst
Copy link
Member

cycling PR to run CI again

@orbeckst orbeckst closed this Mar 24, 2025
@orbeckst orbeckst reopened this Mar 24, 2025
orbeckst
orbeckst approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This particular warning was fixed.

There are more ... but that can be another PR.

@orbeckst orbeckst merged commit 07961c1 into MDAnalysis:develop Mar 24, 2025
6 of 7 checks passed
@mhmohona mhmohona deleted the okwarning branch March 25, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RMeli RMeli RMeli left review comments

@orbeckst orbeckst orbeckst approved these changes

Assignees

@orbeckst orbeckst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specify :okwarning: as an option in the ipython:: block to suppress a warning
3 participants
@mhmohona @RMeli @orbeckst