Update NCDF Reader to read .ncrst Restart Files#5031
Update NCDF Reader to read .ncrst Restart Files#5031jeremyleung521 wants to merge 59 commits intoMDAnalysis:developfrom
Conversation
There was a problem hiding this comment.
Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our Code of Conduct and that first time contributors introduce themselves on GitHub Discussions so we can get to know you. You can learn more about participating here. Please also add yourself to package/AUTHORS as part of this PR.
|
Regarding the status of this PR:
|
|
Ok, thanks for the explanation.
|
IAlibay
left a comment
There was a problem hiding this comment.
Sorry I completely lapsed on reviewing this.
I'm unfortunately going to have to put a pause on this so that it doesn't get eagerly merged into the upcoming release. There's a few things I had in my notes I needed to check before we merged this - mostly AMBER format things.
|
@IAlibay Since it's been a while, I'll ping you again for review :) It's one of the features that our lab really, really needs and it would be nice if it could be implemented. Thanks! |
I'm so sorry @jeremyleung521 - it's been very hard to find time to review this. I'm unfortunately OOO for the next couple of weeks, but I will put it at the top of my todo list at the start of March. Again apologies, I know this has been dragging for a long while. |
Fixes #5030
Changes made in this Pull Request:
.ncrstrestart filesncrstfile is readed correctly. The test file I used is created from a .nc file already present in MDAnalysisTestPR Checklist
package/CHANGELOGfile updated?package/AUTHORS? (If it is not, add it!)Developers Certificate of Origin
I certify that I can submit this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE.
📚 Documentation preview 📚: https://mdanalysis--5031.org.readthedocs.build/en/5031/