DOC: fix doctest output in transformations.py for newer NumPy#5283
DOC: fix doctest output in transformations.py for newer NumPy#5283Kd1880 wants to merge 4 commits intoMDAnalysis:developfrom
Conversation
There was a problem hiding this comment.
Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our Code of Conduct and that first time contributors introduce themselves on GitHub Discussions so we can get to know you. You can learn more about participating here. Please also add yourself to package/AUTHORS as part of this PR.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5283 +/- ##
========================================
Coverage 93.82% 93.82%
========================================
Files 180 182 +2
Lines 22477 22483 +6
Branches 3191 3195 +4
========================================
+ Hits 21089 21095 +6
Misses 925 925
Partials 463 463 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
IAlibay
left a comment
There was a problem hiding this comment.
You removed the AI and other declarations from the PR template. Please add them before we review this PR.
BradyAJohnston
left a comment
There was a problem hiding this comment.
Please use the template available in the repo (https://github.com/MDAnalysis/mdanalysis/blob/develop/.github/PULL_REQUEST_TEMPLATE.md).
It pre-fills when you open a PR on GitHub. Currently you have the changelog message from your other PR also in this PR. Please also update your other PR if you wish for us to review it.
Fixes part of #3925
What was wrong
The doctest in
decompose_matrix()intransformations.pyhad anoutdated expected output. Newer versions of NumPy return
np.float64(0.123)instead of0.123.What I changed
Updated the expected output in the docstring from
0.123to
np.float64(0.123).Tests
Ran
python -m sphinx -b doctest source/ _build/doctest—all 160 doctests in transformations.py now pass.
AI Usage Declaration
AI tools (Claude by Anthropic) were used to help identify and
understand the fix. The actual code change was made manually
by me after understanding the issue.