Fix CDC database download by switching from FTP to HTTPS #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CDC FTP server now returns authentication errors (530 Login authentication failed) when using anonymous FTP with ftplib, and the database filename was changed from trimmed.tfa to alltrimmed.tfa. Changes: - Replace ftplib with urllib.request for direct HTTPS download - Update database filename from trimmed.tfa to alltrimmed.tfa - Modify needs_updating() to accept modified_time parameter - Add proper error handling for HTTP header retrieval - Remove FTP authentication dependency (no longer needed with HTTPS) This fixes the database download functionality and aligns with the working curl-based approach for accessing CDC's EMM database.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CDC FTP server now returns authentication errors (530 Login authentication failed) when using anonymous FTP with ftplib, and the database filename was changed from trimmed.tfa to alltrimmed.tfa.
Issue: Errors when updating database using make_db.py #22
Changes:
This fixes the database download functionality and aligns with the working curl-based approach for accessing CDC's EMM database.